Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Noticed these in #47497
I have a question about the
_ixs
docstring inframe.py
- it says that if a slice is passed, thenthe result is a view. However, the arguments are annotated to be
int
only. Is the docstringcorrect, or is the type annotation too tight?
I presume it's the former, since I'm not able to pass a slice:
Also, typing
_ixs
as that's what's called withinget_item_cache
.For
Series._ixs
, I've annotated the return type asAny
, as that's what the returntype of
Series.pop
is.